Documentation error? With Stock OS running Installer Script while entering fastboot mode for fairphone4 does not work as stated

/e/OS Devices Fairphone
,
33

I think you didn’t. First you started the flash script without having done the unlocking which is definitely in the docs before executing the script. And then you only did half of the unlocking as described in the docs. It says to fastboot flashing unlock_critical, so why didn’t you do it? That command would have avoided your FAILED (remote: 'Flashing is not allowed for Critical Partitions') error.

The steps described in the docs are the same the easy-installer does. I just checked the source code.
And if I look at the docs I find them correct.

I’m not saying that the steps in the install docs are the only way to flash /e/ on an FP4. You obviously found one different way. But for example each of the “reboot into XXX mode” instructions can be done in two or three different ways and people who know what they’re doing can choose whatever method fits them best. For people who do this the first time, it’s best to offer just one alternative IMHO.

Maybe instead of inflating the docs even more I think it would have more impact to extend the flash_FP4_factory.sh script so that it checks that both unlock commands have been properly executed before running the script.

Edit: for linux/mac it should be doable like this:

PHONE_IS_READY=true
if (fastboot getvar is-userspace 2>&1 | grep -q yes); then
    echo "Info:"
    echo "Your phone is in fastbootD mode."
    if (fastboot getvar unlocked 2>&1 | grep -q no); then
        echo "Error:"
        echo "Your phone is still locked."
        echo "Did you execute 'fastboot flashing unlock'?"
        PHONE_IS_READY=false
    fi
else
    echo "Info:"
    echo "Your phone is in regular bootloader mode."
    if (fastboot getvar unlocked 2>&1 | grep -q no); then
        echo "Error:"
        echo "Your phone is still locked."
        echo "Did you execute 'fastboot flashing unlock'?"
        PHONE_IS_READY=false
    fi
    if (fastboot oem device-info 2>&1 | grep -q "critical unlocked: false"); then
        echo "Error:"
        echo "Critical partitions are still locked."
        echo "Did you execute 'fastboot flashing unlock_critical'?"
        PHONE_IS_READY=false
    fi
fi

if [ "$PHONE_IS_READY" = "false" ]; then
    echo "Error:"
    echo "Your phone is not ready for flashing yet (see above), aborting..."
    exit 1
fi
6 Likes